Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docker image with Dockerfile #318

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented Jul 2, 2020

1, For prebuild pipeline, build the latest docker image form the Dockerfile, to make sure the pre-merge pipeline syncs up with any Dockerfile updating.

For the nightly pipeline, check if the image from Docker repo is the same as the lastest one, which is built from Dockerfile. Otherwise, push the latest image onto the Docker repo

For release pipeline, only need to pull a docker image from Docker repo.

Remove "-v /etc/group:/etc/group:ro ..." from docker image, run Jenkins with 26576:30 svcngcc user

2, Only update Jenkins scripts, no source change. No unit tests needed.

3, No Github issue related to the PR.

Don't mount host passwd/group to the container
Remove the local repository info
Build dockerfile after pulling
For prebuild pipeline, build the latest docker image form the Dockerfile, to make sure the pre-merge pipeline syncs up with any Dockerfile updating.

For the nightly pipeline, check if the image from Docker repo is the same as the lastest one, which is built from Dockerfile. Otherwise, push the latest image onto the Docker repo

For release pipeline, only need to pull a docker image from Docker repo.

Remove "-v /etc/group:/etc/group:ro ..." from docker image, run Jenkins with 26576:30 svcngcc user
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Jul 2, 2020

build

@jlowe jlowe added the build Related to CI / CD or cleanly building label Jul 2, 2020
@GaryShen2008 GaryShen2008 merged commit 56e7535 into NVIDIA:branch-0.2 Jul 3, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Use specific uid/gid to run docker container

Don't mount host passwd/group to the container
Remove the local repository info
Build dockerfile after pulling

* Build docker image with Dockerfile

For prebuild pipeline, build the latest docker image form the Dockerfile, to make sure the pre-merge pipeline syncs up with any Dockerfile updating.

For the nightly pipeline, check if the image from Docker repo is the same as the lastest one, which is built from Dockerfile. Otherwise, push the latest image onto the Docker repo

For release pipeline, only need to pull a docker image from Docker repo.

Remove "-v /etc/group:/etc/group:ro ..." from docker image, run Jenkins with 26576:30 svcngcc user

Co-authored-by: gashen <gashen@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Use specific uid/gid to run docker container

Don't mount host passwd/group to the container
Remove the local repository info
Build dockerfile after pulling

* Build docker image with Dockerfile

For prebuild pipeline, build the latest docker image form the Dockerfile, to make sure the pre-merge pipeline syncs up with any Dockerfile updating.

For the nightly pipeline, check if the image from Docker repo is the same as the lastest one, which is built from Dockerfile. Otherwise, push the latest image onto the Docker repo

For release pipeline, only need to pull a docker image from Docker repo.

Remove "-v /etc/group:/etc/group:ro ..." from docker image, run Jenkins with 26576:30 svcngcc user

Co-authored-by: gashen <gashen@nvidia.com>
pxLi pushed a commit to pxLi/spark-rapids that referenced this pull request May 12, 2022
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…p ci] [bot] (NVIDIA#318)

* Update submodule cudf to 4dfd684

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

* Update submodule cudf to aec9007

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

* Update submodule cudf to a00cca6

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

* Update submodule cudf to 6be6466

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

* Update submodule cudf to b7c7adc

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants