Use child type in some places to make it more clear #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
revans2
added
documentation
|
build |
|
child makes it more clear to me but should get others feedback and keep things consistent in our terminology. @sameerz |
jlowe
previously approved these changes
Aug 23, 2021
ttnghia
reviewed
Aug 23, 2021
| } | ||
|
|
||
| /** | ||
| * Combine two type signatures together. Base types and nested types will be the union of | ||
| * Combine two type signatures together. Base types and child types will be the union of |
There was a problem hiding this comment.
Suggested change
| * Combine two type signatures together. Base types and child types will be the union of | |
| * Combine two type signatures together. Base types and child types will be the union of |
Does |
Type of child columns. Not child type as in the |
|
build |
jlowe
previously approved these changes
Aug 25, 2021
|
build |
jlowe
previously approved these changes
Aug 30, 2021
|
build |
|
build |
jlowe
approved these changes
Aug 30, 2021
|
build |
1 similar comment
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used "nested" types in a number of places to refer to a "child" type. This was confusing and this tries to fix it. If needed I can add in a definition of a nested type and a child type to the docs too.