Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests on spark 3.0.1-SNAPSHOT & 3.1.0-SNAPSHOT #335

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Integration tests on spark 3.0.1-SNAPSHOT & 3.1.0-SNAPSHOT #335

merged 2 commits into from
Jul 13, 2020

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented Jul 9, 2020 •
edited
Loading

1, Add integration tests Jenkinsfile on spark 3.0.1-SNAPSHOT & 3.1.0-SNAPSHOT

2, Only update Jenkins scripts, no source change. No unit tests needed.

3, No Github issue related to the PR.

@NvTimLiu
Integration tests on spark 3.0.1-SNAPSHOT & 3.10.-SNAPSHOT
38ccae3 
Add Jenkinsfile for integration tests on spark 3.0.1-SNAPSHOT & 3.10.-SNAPSHOT
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Jul 9, 2020

build

@NvTimLiu NvTimLiu changed the title Integration tests on spark 3.0.1-SNAPSHOT & 3.10.-SNAPSHOT Integration tests on spark 3.0.1-SNAPSHOT & 3.1.0-SNAPSHOT Jul 9, 2020
@NvTimLiu NvTimLiu changed the title Integration tests on spark 3.0.1-SNAPSHOT & 3.1.0-SNAPSHOT WIP: Integration tests on spark 3.0.1-SNAPSHOT & 3.1.0-SNAPSHOT Jul 9, 2020
@jlowe jlowe added the build Related to CI / CD or cleanly building label Jul 9, 2020
jlowe
jlowe requested changes Jul 9, 2020
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of duplication across Jenkins files. Not must-fix for this PR, but it would be nice to have a followup to refactor this if possible. Otherwise every time we want to tweak something in the integration test pipelines we need to remember to make that same change in a bunch of other files (e.g.: updating the slack method).

jenkins/Jenkinsfile.301.integration Outdated Show resolved Hide resolved
jenkins/Jenkinsfile.310.integration Outdated Show resolved Hide resolved
jenkins/Jenkinsfile.301.integration Outdated Show resolved Hide resolved
jenkins/Jenkinsfile.310.integration Outdated Show resolved Hide resolved
@NvTimLiu
Copy link
Collaborator Author

There's a lot of duplication across Jenkins files. Not must-fix for this PR, but it would be nice to have a followup to refactor this if possible. Otherwise every time we want to tweak something in the integration test pipelines we need to remember to make that same change in a bunch of other files (e.g.: updating the slack method).

Good suggestion!
I'll investigate how to refactor these Jenkinsfiles

@NvTimLiu NvTimLiu changed the title WIP: Integration tests on spark 3.0.1-SNAPSHOT & 3.1.0-SNAPSHOT Integration tests on spark 3.0.1-SNAPSHOT & 3.1.0-SNAPSHOT Jul 10, 2020
@NvTimLiu
Copy link
Collaborator Author

build

revans2
revans2 approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @jlowe is out for a bit longer and it looks like his requests were all addressed I think we can merge this in.

@revans2
Copy link
Collaborator

revans2 commented Jul 13, 2020

build

@revans2 revans2 merged commit 743924c into NVIDIA:branch-0.2 Jul 13, 2020
@sameerz sameerz added this to the Jul 6 - Jul 17 milestone Jul 17, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@NvTimLiu
Integration tests on spark 3.0.1-SNAPSHOT & 3.1.0-SNAPSHOT (NVIDIA#335)
ab80adb 
* Integration tests on spark 3.0.1-SNAPSHOT & 3.10.-SNAPSHOT

Add Jenkinsfile for integration tests on spark 3.0.1-SNAPSHOT & 3.10.-SNAPSHOT

* Fix copyright and spark version anotations

Co-authored-by: Tim Liu <timl@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@NvTimLiu
Integration tests on spark 3.0.1-SNAPSHOT & 3.1.0-SNAPSHOT (NVIDIA#335)
63f8f02 
* Integration tests on spark 3.0.1-SNAPSHOT & 3.10.-SNAPSHOT

Add Jenkinsfile for integration tests on spark 3.0.1-SNAPSHOT & 3.10.-SNAPSHOT

* Fix copyright and spark version anotations

Co-authored-by: Tim Liu <timl@nvidia.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
@nvauto
Update submodule cudf to ef6a390 (NVIDIA#335)
ab4fb5e 
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe requested changes

@revans2 revans2 revans2 approved these changes

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
Jul 6 - Jul 17
Development

Successfully merging this pull request may close these issues.
4 participants
@NvTimLiu @revans2 @jlowe @sameerz