Implement build-side rules for shuffle hash join #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
|
overall this makes sense. At the time I implemented this I think all we supported was left and inner joins and I probably should have tagged it better to ensure that. |
tgravescs
reviewed
Jul 10, 2020
| condition.map(_.convertToGpu()), | ||
| childPlans(0).convertIfNeeded(), | ||
| childPlans(1).convertIfNeeded()) | ||
| } | ||
|
|
||
| private def canBuildRight(joinType: JoinType): Boolean = joinType match { |
There was a problem hiding this comment.
might be nice to add comment about these must match the spark join selection critera for ShuffledHashJoinExec
|
build |
andygrove
changed the title
sameerz
added
performance
revans2
approved these changes
Jul 13, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the same logic that Spark uses to determine whether the left or right side of a shuffle hash join can safely be used as the build side.
This fixed one test failure in the AQE proof-of-concept work (hash right join).