Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify unshimmed classes are bitwise-identical #3645

Merged

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Sep 24, 2021

Closes #3582

  • make sure that count distinct md5sum for classes moved to the top of the jar / is 1
  • delete duplicates from parallel worlds after that

Signed-off-by: Gera Shegalov gera@apache.org

across all shims

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov added the build Related to CI / CD or cleanly building label Sep 24, 2021
@gerashegalov gerashegalov added this to the Sep 13 - Sep 24 milestone Sep 24, 2021
@gerashegalov gerashegalov self-assigned this Sep 24, 2021
@gerashegalov
Copy link
Collaborator Author

build

tgravescs
tgravescs previously approved these changes Sep 24, 2021
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov merged commit ba16a19 into NVIDIA:branch-21.10 Sep 24, 2021
@gerashegalov gerashegalov deleted the validateUnshimmedByteCode branch September 24, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Verify unshimmed-base classes are identical across shims
2 participants