Explicitly use the public version of ParquetCachedBatchSerializer #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring accidentally used the shimmed implementation class instead of facade. Need a separate issue to remove consolidate this code in a single class as it's currently replicated a few times in the repo Signed-off-by: Gera Shegalov <gera@apache.org>
|
build |
revans2
approved these changes
Nov 3, 2021
abellina
approved these changes
Nov 3, 2021
|
Do we also want to hide the concrete class so even if a user specifies |
razajafri
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring accidentally used the shimmed implementation class instead
of the facade API.
We need a separate issue to remove / consolidate this code in a single class
as it's currently replicated a few times in the repo
Closes #3999
Signed-off-by: Gera Shegalov gera@apache.org