Add partial support for line begin and end anchors in regexp_replace #4155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
jlowe
changed the title
jlowe
reviewed
Nov 18, 2021
tests/src/test/scala/com/nvidia/spark/rapids/RegularExpressionTranspilerSuite.scala
Show resolved
Hide resolved
| || isRegexChar(parts.head, '$'))) { | ||
| throw new RegexUnsupportedException("regexp_replace on GPU does not support ^ or $") | ||
| if (parts.forall { | ||
| case RegexChar(ch) => ch == '^' || ch == '$' |
There was a problem hiding this comment.
Do we need to worry about any degenerate cases of other directives (e.g.: empty group, character class, etc.) that would essentially be equivalent to just having these characters in the pattern?
There was a problem hiding this comment.
For empty groups, we would fall back to CPU, but I did find one case that is not detected by this rule ((^)($)) so will spend some more time on this.
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
|
Converting this to WIP since there are regressions caused by other regexp PRs that were recently merged |
|
build |
andygrove
changed the title
|
build |
1 similar comment
|
build |
andygrove
commented
Dec 21, 2021
| patterns.foreach(pattern => | ||
| assertUnsupported(pattern, "nothing to repeat")) | ||
| assertUnsupported(pattern, replace = false, | ||
| "cuDF does not support null characters in regular expressions")) | ||
| } |
There was a problem hiding this comment.
This test is no longer valid and the patterns tested here have moved to a different test
|
Sign-off check is failing due to: |
|
build |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4091