Fix duplicates includes in assembly jar #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
revans2
approved these changes
Jul 24, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Fix duplicates includes * only include META-INF Co-authored-by: Thomas Graves <tgraves@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Fix duplicates includes * only include META-INF Co-authored-by: Thomas Graves <tgraves@nvidia.com>
pxLi
pushed a commit
to pxLi/spark-rapids
that referenced
this pull request
May 12, 2022
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After shimlayer was merged if you didn't clean you saw an error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.1:shade (default) on project rapids-4-spark_2.12: Error creating shaded jar: duplicate entry: META-INF/services/com.nvidia.shaded.spark.orc.DataMask$Provider -> [Help 1]
The problem was actually there already that we are including the already built assembly jar, the new service loader transformer that was added just caused it to fail.
This modifies it to only include the META-INF pom file from that package when assembling:
0 Thu Jul 23 21:51:06 CDT 2020 META-INF/maven/com.nvidia/rapids-4-spark_2.12/
5987 Thu Jul 23 21:47:32 CDT 2020 META-INF/maven/com.nvidia/rapids-4-spark_2.12/pom.xml
123 Thu Jul 23 21:50:08 CDT 2020 META-INF/maven/com.nvidia/rapids-4-spark_2.12/pom.properties
This is what we were including previously.