Add support for regexp_extract on the GPU #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
andygrove
commented
Dec 3, 2021
Comment on lines
-511
to
-479
| - `$` does not match the end of a string if the string ends with a line-terminator | ||
| ([cuDF issue #9620](https://github.com/rapidsai/cudf/issues/9620)) |
There was a problem hiding this comment.
This issue was resolved in #4239 but the docs did not get updated. I can raise a separate PR for this change if necessary.
|
build |
andygrove
changed the title
andygrove
force-pushed
the
regexp-extract
branch
from
3ace09d
to
62ac1ef
Compare
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
regexp-extract
branch
from
90f174f
to
d8c9c0e
Compare
andygrove
changed the title
andygrove
commented
Dec 7, 2021
| withResource(str.getBase.extractRe(cudfRegexPattern)) { extract => | ||
| withResource(str.getBase.matchesRe(cudfRegexPattern)) { matches => | ||
| withResource(str.getBase.isNull) { isNull => | ||
| withResource(extract.getColumn(i - 1)) { extractedGroup => |
There was a problem hiding this comment.
It would be nice if we could just ask cuDF to extract a single column and I have filed rapidsai/cudf#9855 to request that capability
andygrove
commented
Dec 9, 2021
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Show resolved
Hide resolved
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
jlowe
reviewed
Dec 10, 2021
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
andygrove
changed the title
jlowe
previously approved these changes
Dec 10, 2021
|
build |
jlowe
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Closes #4002 and #4284
This PR adds support for
regexp_extract.