Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unnecessary parameter dataType in resolveColumnVector method #4340

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Remove the unnecessary parameter dataType in resolveColumnVector method #4340

merged 1 commit into from
Dec 10, 2021

Conversation

firestarman
Copy link
Collaborator

This fixes #4339

Signed-off-by: Firestarman firestarmanllc@gmail.com

@firestarman
Remove the unnecessary parameter
a539bf8 
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
@firestarman
Copy link
Collaborator Author

build

@sperlingxx
Copy link
Collaborator

LGTM

@sperlingxx sperlingxx self-requested a review December 10, 2021 02:34
sperlingxx
sperlingxx approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@sperlingxx sperlingxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@firestarman firestarman merged commit f99a57b into NVIDIA:branch-22.02 Dec 10, 2021
@firestarman firestarman deleted the remove-datatype branch December 10, 2021 04:24
@sameerz sameerz added the task Work required that improves the product but is not user facing label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sperlingxx sperlingxx sperlingxx approved these changes

@GaryShen2008 GaryShen2008 GaryShen2008 left review comments

Assignees
No one assigned
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The parameter dataType is not necessary in resolveColumnVector method.
4 participants
@firestarman @sperlingxx @GaryShen2008 @sameerz