Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GpuIf to support expressions with side effects #4358

Merged
merged 15 commits into from
Dec 17, 2021
Merged

Update GpuIf to support expressions with side effects #4358

merged 15 commits into from
Dec 17, 2021

Commits on Dec 14, 2021

  1. Update GpuIf to support expressions with side effects 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    2baf9eb View commit details
    Browse the repository at this point in the history

  2. prep for review 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    b236f39 View commit details
    Browse the repository at this point in the history

  3. improve checks for all true/false 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    c1943f0 View commit details
    Browse the repository at this point in the history

  4. refactor for readability and add documentation

    @andygrove
    andygrove committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    5620ca5 View commit details
    Browse the repository at this point in the history

  5. improve GpuCast side-effect check 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    f5f6f12 View commit details
    Browse the repository at this point in the history

  6. release resources earlier

    @andygrove
    andygrove committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    7d097ed View commit details
    Browse the repository at this point in the history

  7. remove isValid check

    @andygrove
    andygrove committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    b6b865f View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/conditionalE… 

    …xpressions.scala

Co-authored-by: Liangcai Li <firestarmanllc@gmail.com>
    @andygrove @firestarman
    andygrove and firestarman authored Dec 15, 2021
    Configuration menu
    Copy the full SHA
    96567bb View commit details
    Browse the repository at this point in the history

  2. Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/conditionalE… 

    …xpressions.scala

Co-authored-by: Liangcai Li <firestarmanllc@gmail.com>
    @andygrove @firestarman
    andygrove and firestarman authored Dec 15, 2021
    Configuration menu
    Copy the full SHA
    0c706f4 View commit details
    Browse the repository at this point in the history

  3. fix resource leak and add test for CAST 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    ee83339 View commit details
    Browse the repository at this point in the history

  4. revert add blank line

    @andygrove
    andygrove committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    fcdc541 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/conditionalE… 

    …xpressions.scala

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
    @andygrove @jlowe
    andygrove and jlowe authored Dec 16, 2021
    Configuration menu
    Copy the full SHA
    54488eb View commit details
    Browse the repository at this point in the history

  2. partially address PR review feedback 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    7b87af6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'gpu-if-side-effect' of github.com:andygrove/spark-rapid… 

    …s into gpu-if-side-effect
    @andygrove
    andygrove committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    d6d724f View commit details
    Browse the repository at this point in the history

  4. Change gather signature to return ColumnVector. Also add missing import. 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    bee0643 View commit details
    Browse the repository at this point in the history