-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with InSet and Strings #437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
build |
abellina
requested changes
Jul 27, 2020
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
jlowe
approved these changes
Jul 27, 2020
build |
@abellina any more concerns? |
abellina
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @revans2
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Fix bug with InSet and Strings Signed-off-by: Robert (Bobby) Evans <bobby@apache.org> * Addressed review comments Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Fix bug with InSet and Strings Signed-off-by: Robert (Bobby) Evans <bobby@apache.org> * Addressed review comments Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
pxLi
pushed a commit
to pxLi/spark-rapids
that referenced
this pull request
May 12, 2022
…DIA#437) * Add Ditto helper to app_common, update prostate example learners * Correct a bug in local valid * refactor DittoHelper * remove a redundant lr in DittoHelper * remove a redundant lr in DittoHelper * remove a redundant lr in DittoHelper * format adjustment * refactor Ditto helper with abstract method * further touchups on ditto helper class and supervised learner * add type hint and check with default
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
[auto-merge] bot-auto-merge-branch-22.08 to branch-22.10 [skip ci] [bot]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #433
Literal.apply
does not work if the value is aUTF8String
. This fixes that issue.