Add pytest tags for nightly test parallel run [skip ci] #4373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
tgravescs
reviewed
Dec 16, 2021
integration_tests/pytest.ini
Outdated
| @@ -26,5 +26,8 @@ markers = | |||
| validate_execs_in_gpu_plan([execs]): Exec class names to validate they exist in the GPU plan. | |||
| shuffle_test: Mark to include test in the RAPIDS Shuffle Manager | |||
| premerge_ci_1: Mark test that will run in first k8s pod in case of parallel build premerge job | |||
| nightly_test_to_cases: tests either time-consuming or mem-consuming, we split them into cases in nightly | |||
There was a problem hiding this comment.
I'm not sure I understand what the to_cases description here? does this mark entire file and then if you want just a single test you use the nightly_*case ones? if I saw this I would not think of time consuming or mem consuming so I think we should rename.
There was a problem hiding this comment.
nightly_test_to_cases this mark the entire test file (most of cases are time consuming) which will be split into cases in parallel run
So we parallel
- special cases in nightly_test_to_cases
- nightly_test_to_cases
- other tests files
let me try rename this to something meaningful
There was a problem hiding this comment.
@tgravescs renamed to nightly_resource_consuming_test, please let me know if this sounds OK, thx~
|
build |
|
build |
tgravescs
approved these changes
Dec 17, 2021
|
Going to merge and trigger internal build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peixin Li pxli@nyu.edu
fix #4348.
added 3 new pytest tags to better differentiate tests/cases used in spark-tests.sh script