Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix correctness issue with CASE WHEN with expressions that have side-effects #4383

Merged
merged 22 commits into from
Jan 6, 2022
Merged

Fix correctness issue with CASE WHEN with expressions that have side-effects #4383

merged 22 commits into from
Jan 6, 2022

Commits on Dec 17, 2021

  1. Fix correctness issue with CASE WHEN with expressions that have side-… 

    …effects

Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    aa6db16 View commit details
    Browse the repository at this point in the history

  2. code cleanup and comments

    @andygrove
    andygrove committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    e0879f9 View commit details
    Browse the repository at this point in the history

  3. Revert unnecessary change

    @andygrove
    andygrove committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    5756850 View commit details
    Browse the repository at this point in the history

  4. Revert unnecessary change

    @andygrove
    andygrove committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    f509f69 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. Add license header 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    58bfdad View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Add more comments. Add optimization to stop processing branches once … 

    …cumulativePred is true

Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    5b5247d View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/conditionalE… 

    …xpressions.scala

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
    @andygrove @jlowe
    andygrove and jlowe authored Dec 22, 2021
    Configuration menu
    Copy the full SHA
    e9e5f50 View commit details
    Browse the repository at this point in the history

  2. Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/conditionalE… 

    …xpressions.scala

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
    @andygrove @jlowe
    andygrove and jlowe authored Dec 22, 2021
    Configuration menu
    Copy the full SHA
    58d2c26 View commit details
    Browse the repository at this point in the history

  3. Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/conditionalE… 

    …xpressions.scala

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
    @andygrove @jlowe
    andygrove and jlowe authored Dec 22, 2021
    Configuration menu
    Copy the full SHA
    2ffd030 View commit details
    Browse the repository at this point in the history

  4. remove redundant check

    @andygrove
    andygrove committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    044c98a View commit details
    Browse the repository at this point in the history

  5. close thenValues resource earlier

    @andygrove
    andygrove committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    e83b187 View commit details
    Browse the repository at this point in the history

  6. close elseValues resource earlier

    @andygrove
    andygrove committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    76d63a4 View commit details
    Browse the repository at this point in the history

  7. refactor for readability

    @andygrove
    andygrove committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    89da423 View commit details
    Browse the repository at this point in the history

  8. refactor to remove duplicate code

    @andygrove
    andygrove committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    96fc175 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. simplify inverting cumulativePred for else condition

    @andygrove
    andygrove committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    4a79414 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'nvidia/branch-22.02' into gpu-case-when… 

    …-side-effect
    @andygrove
    andygrove committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    aad30f4 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/conditionalE… 

    …xpressions.scala

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
    @andygrove @jlowe
    andygrove and jlowe authored Jan 5, 2022
    Configuration menu
    Copy the full SHA
    1233870 View commit details
    Browse the repository at this point in the history

  2. fix compilation error

    @andygrove
    andygrove committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    bde6b85 View commit details
    Browse the repository at this point in the history

  3. Use AST NULL_LOGICAL_OR for computing cumulative predicate

    @andygrove
    andygrove committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    034cc01 View commit details
    Browse the repository at this point in the history

  4. Update isFirstTrueWhen to be null-safe

    @andygrove
    andygrove committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    5ae6922 View commit details
    Browse the repository at this point in the history

  5. address feedback

    @andygrove
    andygrove committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    bb80e29 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Add tests for predicates evaluating to null

    @andygrove
    andygrove committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    98d2207 View commit details
    Browse the repository at this point in the history