Update getFileScanRDD shim for recent changes in Spark 3.3.0 [databricks] #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
jlowe
changed the title
|
build |
|
build |
revans2
approved these changes
Dec 22, 2021
|
Do you know what the change was for? |
Yes, details are in #4426 and the linked Spark JIRA. Spark 3.3 added support for loading "hidden" metadata if specified explicitly. This PR just gets us building again, but we'll need to properly handle this feature, either by implementing the metadata columns for the GPU or falling back to the CPU if they are detected in the read schema, when we start officially supporting Spark 3.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4423. Updated the
getFileScanRDDshim interface to take the read data schema and metadata columns, and updated the only place this is called to pass the read data schema. I filed #4426 to track handling the new hidden metadata column functionality added in 3.3.0.