Print error log to stderr output

[res-life]

Signed-off-by: Chong Gao res_life@163.com

[res-life]

build

[firestarman]

May I know why need to do this ?

[firestarman]

Missing the original empty echo, who will print a space line.

[res-life]

It's a empty line for show, can be removed.

[gerashegalov]

Can we add more diagnostics to the log while we are at it? What are the git rev values that are different? What shim_version_path do they originate from?

[res-life]

Sure, I'll update it.

[res-life]

The msg in stderr will be saved in the parameter ${build-parallel-worlds.checkRevisionsErrorMsg}. If not print to stderr, the parameter ${build-parallel-worlds.checkRevisionsErrorMsg} is empty.

See the following:

        <!-- check shims revisions -->
        <exec executable="${project.basedir}/scripts/check-shims-revisions.sh"
              dir="${project.build.directory}"
              resultproperty="build-parallel-worlds.checkRevisionsExitCode"
              errorproperty="build-parallel-worlds.checkRevisionsErrorMsg"
              failonerror="false">
            <arg value="${included_buildvers}"/>
        </exec>
        <fail message="exec check-shims-revisions.sh failed, exit code is ${build-parallel-worlds.checkRevisionsExitCode}, error msg is ${build-parallel-worlds.checkRevisionsErrorMsg}">
            <condition>
                <not>
                    <equals arg1="${build-parallel-worlds.checkRevisionsExitCode}" arg2="0"/>
                </not>
            </condition>
        </fail>

[gerashegalov]

The msg in stderr will be saved in the parameter ${build-parallel-worlds.checkRevisionsErrorMsg}. If not print to stderr, the parameter ${build-parallel-worlds.checkRevisionsErrorMsg} is empty.

I missed that in the review too, although I thought I saw this working. Did you test it?

[res-life]

I missed that in the review too, although I thought I saw this working. Did you test it?

Yes, tested, it works. If versions are inconsistent , the error is

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:3.0.0:run (create-parallel-world) on project rapids-4-spark_2.12: An Ant BuildException has occured: The following error occurred while executing this line:
[ERROR] /home/chong/code/spark-rapids/dist/maven-antrun/build-parallel-worlds.xml:134: exec check-shims-revisions.sh failed, exit code is 1, error msg is Check Failed: git revisions between shims are not equal
[ERROR] Please check the revisions of each shim to see which one is inconsistent. Note, if building with Databricks those jars are built separately.
[ERROR] around Ant part ...<ant antfile="/home/chong/code/spark-rapids/dist/maven-antrun/build-parallel-worlds.xml" target="build-parallel-worlds" />... @ 9:127 in /home/chong/code/spark-rapids/dist/target/antrun/build-main.xml
[ERROR] -> [Help 1]

[res-life]

build

[res-life]

build