Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix broken build and rework shims after SPARK-37705 for Spark 3.3.0 #4444

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@
<source>${project.basedir}/src/main/311until320-all/scala</source>
<source>${project.basedir}/src/main/311until320-noncdh/scala</source>
<source>${project.basedir}/src/main/311until320-nondb/scala</source>
<source>${project.basedir}/src/main/311until330-all/scala</source>
<source>${project.basedir}/src/main/pre320-treenode/scala</source>
</sources>
</configuration>
Expand Down Expand Up @@ -403,6 +404,7 @@
<source>${project.basedir}/src/main/301until330-all/scala</source>
<source>${project.basedir}/src/main/311until320-all/scala</source>
<source>${project.basedir}/src/main/311+-all/scala</source>
<source>${project.basedir}/src/main/311until330-all/scala</source>
<source>${project.basedir}/src/main/311until320-noncdh/scala</source>
<source>${project.basedir}/src/main/31xdb/scala</source>
<source>${project.basedir}/src/main/post320-treenode/scala</source>
Expand Down Expand Up @@ -446,6 +448,7 @@
<source>${project.basedir}/src/main/301until320-nondb/scala</source>
<source>${project.basedir}/src/main/301until330-all/scala</source>
<source>${project.basedir}/src/main/311+-all/scala</source>
<source>${project.basedir}/src/main/311until330-all/scala</source>
<source>${project.basedir}/src/main/311+-nondb/scala</source>
<source>${project.basedir}/src/main/311until320-all/scala</source>
<source>${project.basedir}/src/main/311until320-noncdh/scala</source>
Expand Down Expand Up @@ -494,6 +497,7 @@
<source>${project.basedir}/src/main/301until320-nondb/scala</source>
<source>${project.basedir}/src/main/301until330-all/scala</source>
<source>${project.basedir}/src/main/311+-all/scala</source>
<source>${project.basedir}/src/main/311until330-all/scala</source>
<source>${project.basedir}/src/main/311+-nondb/scala</source>
<source>${project.basedir}/src/main/311until320-all/scala</source>
<source>${project.basedir}/src/main/311until320-noncdh/scala</source>
Expand Down Expand Up @@ -540,6 +544,7 @@
<source>${project.basedir}/src/main/301+-nondb/scala</source>
<source>${project.basedir}/src/main/301until330-all/scala</source>
<source>${project.basedir}/src/main/311+-all/scala</source>
<source>${project.basedir}/src/main/311until330-all/scala</source>
<source>${project.basedir}/src/main/311+-nondb/scala</source>
<source>${project.basedir}/src/main/320+/scala</source>
<source>${project.basedir}/src/main/post320-treenode/scala</source>
Expand Down Expand Up @@ -583,6 +588,7 @@
<source>${project.basedir}/src/main/301+-nondb/scala</source>
<source>${project.basedir}/src/main/301until330-all/scala</source>
<source>${project.basedir}/src/main/311+-all/scala</source>
<source>${project.basedir}/src/main/311until330-all/scala</source>
<source>${project.basedir}/src/main/311+-nondb/scala</source>
<source>${project.basedir}/src/main/320+/scala</source>
<source>${project.basedir}/src/main/post320-treenode/scala</source>
Expand Down
4 changes: 4 additions & 0 deletions shims/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@
<id>release321</id>
<modules><module>spark321</module></modules>
</profile>
<profile>
<id>release330</id>
<modules><module>spark330</module></modules>
</profile>
</profiles>

<dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,12 @@ class Spark301Shims extends Spark30XShims with Spark30Xuntil33XShims {
pushDownStartWith: Boolean,
pushDownInFilterThreshold: Int,
caseSensitive: Boolean,
datetimeRebaseMode: SQLConf.LegacyBehaviorPolicy.Value): ParquetFilters = {
datetimeRebaseMode: Any): ParquetFilters = {
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive)
}

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,12 @@ class Spark302Shims extends Spark30XShims with Spark30Xuntil33XShims {
pushDownStartWith: Boolean,
pushDownInFilterThreshold: Int,
caseSensitive: Boolean,
datetimeRebaseMode: SQLConf.LegacyBehaviorPolicy.Value): ParquetFilters = {
datetimeRebaseMode: Any): ParquetFilters = {
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive)
}

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,12 @@ class Spark303Shims extends Spark30XShims with Spark30Xuntil33XShims {
pushDownStartWith: Boolean,
pushDownInFilterThreshold: Int,
caseSensitive: Boolean,
datetimeRebaseMode: SQLConf.LegacyBehaviorPolicy.Value): ParquetFilters = {
datetimeRebaseMode: Any): ParquetFilters = {
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive)
}

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,12 @@ class Spark304Shims extends Spark30XShims with Spark30Xuntil33XShims {
pushDownStartWith: Boolean,
pushDownInFilterThreshold: Int,
caseSensitive: Boolean,
datetimeRebaseMode: SQLConf.LegacyBehaviorPolicy.Value): ParquetFilters =
datetimeRebaseMode: Any): ParquetFilters =
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive, datetimeRebaseMode)
pushDownInFilterThreshold, caseSensitive, datetimeRebaseMode.asInstanceOf[
SQLConf.LegacyBehaviorPolicy.Value])

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,8 @@ class Spark311Shims extends Spark31XShims with Spark30Xuntil33XShims {
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive)
}

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,8 @@ class Spark311CDHShims extends Spark31XShims with Spark30Xuntil33XShims {
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive)
}

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,8 @@ class Spark312Shims extends Spark31XShims with Spark30Xuntil33XShims {
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive)
}

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,12 @@ class Spark312dbShims extends Spark31XdbShims with Spark30Xuntil33XShims {
pushDownStartWith: Boolean,
pushDownInFilterThreshold: Int,
caseSensitive: Boolean,
datetimeRebaseMode: SQLConf.LegacyBehaviorPolicy.Value): ParquetFilters =
datetimeRebaseMode: Any): ParquetFilters =
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive, datetimeRebaseMode)
pushDownInFilterThreshold, caseSensitive, datetimeRebaseMode.asInstanceOf[
SQLConf.LegacyBehaviorPolicy.Value])

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,14 @@ class Spark313Shims extends Spark31XShims with Spark30Xuntil33XShims {
pushDownStartWith: Boolean,
pushDownInFilterThreshold: Int,
caseSensitive: Boolean,
datetimeRebaseMode: SQLConf.LegacyBehaviorPolicy.Value): ParquetFilters =
datetimeRebaseMode: Any): ParquetFilters =
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive, datetimeRebaseMode)
pushDownInFilterThreshold, caseSensitive, datetimeRebaseMode.asInstanceOf[
SQLConf.LegacyBehaviorPolicy.Value])

override def hasCastFloatTimestampUpcast: Boolean = true

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,15 @@ package com.nvidia.spark.rapids.shims.spark320

import com.nvidia.spark.rapids._
import com.nvidia.spark.rapids.shims.v2._
import org.apache.parquet.schema.MessageType

import org.apache.spark.rdd.RDD
import org.apache.spark.sql.SparkSession
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions.AttributeReference
import org.apache.spark.sql.execution.datasources.{FilePartition, FileScanRDD, PartitionedFile}
import org.apache.spark.sql.execution.datasources.{DataSourceUtils, FilePartition, FileScanRDD, PartitionedFile}
import org.apache.spark.sql.execution.datasources.parquet.ParquetFilters
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.StructType

class Spark320Shims extends Spark32XShims with Spark30Xuntil33XShims {
Expand All @@ -37,4 +40,22 @@ class Spark320Shims extends Spark32XShims with Spark30Xuntil33XShims {
metadataColumns: Seq[AttributeReference]): RDD[InternalRow] = {
new FileScanRDD(sparkSession, readFunction, filePartitions)
}

override final def getParquetFilters(
schema: MessageType,
pushDownDate: Boolean,
pushDownTimestamp: Boolean,
pushDownDecimal: Boolean,
pushDownStartWith: Boolean,
pushDownInFilterThreshold: Int,
caseSensitive: Boolean,
datetimeRebaseMode: Any): ParquetFilters = {
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive, datetimeRebaseMode.asInstanceOf[
SQLConf.LegacyBehaviorPolicy.Value])
}

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,15 @@ package com.nvidia.spark.rapids.shims.spark321

import com.nvidia.spark.rapids._
import com.nvidia.spark.rapids.shims.v2._
import org.apache.parquet.schema.MessageType

import org.apache.spark.rdd.RDD
import org.apache.spark.sql.SparkSession
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions.AttributeReference
import org.apache.spark.sql.execution.datasources.{FilePartition, FileScanRDD, PartitionedFile}
import org.apache.spark.sql.execution.datasources.{DataSourceUtils, FilePartition, FileScanRDD, PartitionedFile}
import org.apache.spark.sql.execution.datasources.parquet.ParquetFilters
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.StructType

class Spark321Shims extends Spark32XShims with Spark30Xuntil33XShims {
Expand All @@ -37,4 +40,21 @@ class Spark321Shims extends Spark32XShims with Spark30Xuntil33XShims {
metadataColumns: Seq[AttributeReference]): RDD[InternalRow] = {
new FileScanRDD(sparkSession, readFunction, filePartitions)
}
override final def getParquetFilters(
schema: MessageType,
pushDownDate: Boolean,
pushDownTimestamp: Boolean,
pushDownDecimal: Boolean,
pushDownStartWith: Boolean,
pushDownInFilterThreshold: Int,
caseSensitive: Boolean,
datetimeRebaseMode: Any): ParquetFilters = {
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive, datetimeRebaseMode.asInstanceOf[
SQLConf.LegacyBehaviorPolicy.Value])
}

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseMode(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/*
* Copyright (c) 2021, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.sql.execution.datasources.parquet.rapids.shims.v2

import java.time.ZoneId

import org.apache.parquet.column.ColumnDescriptor
import org.apache.parquet.column.page.PageReadStore
import org.apache.parquet.schema.{GroupType, Type}

import org.apache.spark.sql.execution.datasources.parquet.{ParentContainerUpdater, ParquetRowConverter, ParquetToSparkSchemaConverter, VectorizedColumnReader}
import org.apache.spark.sql.internal.SQLConf.LegacyBehaviorPolicy
import org.apache.spark.sql.types.StructType

class ShimParquetRowConverter(
schemaConverter: ParquetToSparkSchemaConverter,
parquetType: GroupType,
catalystType: StructType,
convertTz: Option[ZoneId],
datetimeRebaseMode: LegacyBehaviorPolicy.Value,
int96RebaseMode: LegacyBehaviorPolicy.Value,
int96CDPHive3Compatibility: Boolean,
updater: ParentContainerUpdater
) extends ParquetRowConverter(
schemaConverter,
parquetType,
catalystType,
convertTz,
datetimeRebaseMode,
int96RebaseMode,
updater)

class ShimVectorizedColumnReader(
index: Int,
columns: java.util.List[ColumnDescriptor],
types: java.util.List[Type],
pageReadStore: PageReadStore,
convertTz: ZoneId,
datetimeRebaseMode: String,
int96RebaseMode: String,
int96CDPHive3Compatibility: Boolean
) extends VectorizedColumnReader(
columns.get(index),
types.get(index).getLogicalTypeAnnotation,
pageReadStore.getPageReader(columns.get(index)),
pageReadStore.getRowIndexes().orElse(null),
convertTz,
datetimeRebaseMode,
int96RebaseMode)
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,26 @@ package com.nvidia.spark.rapids.shims.spark330
import com.nvidia.spark.rapids._
import com.nvidia.spark.rapids.shims.v2._

class Spark330Shims extends Spark33XShims {
import org.apache.spark.sql.catalyst.util.RebaseDateTime.RebaseSpec
import org.apache.spark.sql.execution.datasources.parquet.ParquetFilters

class Spark330Shims extends Spark33XShims with Spark30Xuntil33XShims {
override def getSparkShimVersion: ShimVersion = SparkShimServiceProvider.VERSION

override final def getParquetFilters(
schema: MessageType,
pushDownDate: Boolean,
pushDownTimestamp: Boolean,
pushDownDecimal: Boolean,
pushDownStartWith: Boolean,
pushDownInFilterThreshold: Int,
caseSensitive: Boolean,
datetimeRebaseSpec: Any): ParquetFilters = {
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive, datetimeRebaseSpec.asInstanceOf[RebaseSpec])
}

def getDateTimeRebaseMode(lookupFileMeta: String => String,
modeByConfig: String) : Any = DataSourceUtils.datetimeRebaseSpec(
lookupFileMeta, modeByConfig)
}
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,10 @@ abstract class Spark30XdbShims extends Spark30XdbShimsBase with Logging {
pushDownStartWith: Boolean,
pushDownInFilterThreshold: Int,
caseSensitive: Boolean,
datetimeRebaseMode: SQLConf.LegacyBehaviorPolicy.Value): ParquetFilters =
datetimeRebaseMode: Any): ParquetFilters =
new ParquetFilters(schema, pushDownDate, pushDownTimestamp, pushDownDecimal, pushDownStartWith,
pushDownInFilterThreshold, caseSensitive, datetimeRebaseMode)
pushDownInFilterThreshold, caseSensitive, datetimeRebaseMode.asInstanceOf[
SQLConf.LegacyBehaviorPolicy.Value])

override def v1RepairTableCommand(tableName: TableIdentifier): RunnableCommand =
AlterTableRecoverPartitionsCommand(tableName)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,14 @@

package com.nvidia.spark.rapids.shims.v2

import com.nvidia.spark.rapids.{GpuParquetScanBase, RapidsConf}
import com.nvidia.spark.rapids.{Arm, GpuParquetPartitionReaderFactoryBase, GpuParquetScanBase, ParquetFileInfoWithBlockMeta, ParquetPartitionReader, RapidsConf, ShimLoader}
import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.fs.Path
import org.apache.parquet.column.ColumnDescriptor
import org.apache.parquet.filter2.predicate.FilterApi
import org.apache.parquet.format.converter.ParquetMetadataConverter
import org.apache.parquet.hadoop.{ParquetFileReader, ParquetInputFormat}
import org.apache.parquet.hadoop.metadata.ColumnPath

import org.apache.spark.sql.SparkSession
import org.apache.spark.sql.catalyst.expressions.Expression
Expand Down
Loading