Add recursive type checking and fallback tests for casting array with unsupported element types to string #4449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Map to unsupported element types in IT replace xfail by fallback when casting unsupported types to string in IT Signed-off-by: remzi <13716567376yh@gmail.com>
|
build |
firestarman
reviewed
Dec 31, 2021
| ARRAY + BINARY + STRUCT + MAP) + | ||
| psNote(TypeEnum.ARRAY, "The array's child type must also support being cast to " + | ||
| "the desired child type") | ||
| psNote(TypeEnum.ARRAY, "The array's children must also support being cast to the " + |
There was a problem hiding this comment.
The array type has only one child type. So child type is good enough.
There was a problem hiding this comment.
Thank you, I will fix it
revans2
previously approved these changes
Jan 3, 2022
| @@ -124,6 +124,9 @@ final class CastExprMeta[INPUT <: CastBase]( | |||
| case (fromChild, toChild) => | |||
| recursiveTagExprForGpuCheck(fromChild.dataType, toChild.dataType, depth + 1) | |||
| } | |||
| case (ArrayType(element_type, _), StringType) => | |||
There was a problem hiding this comment.
nit element_type does not follow the convention. Could we make it elementType?
There was a problem hiding this comment.
Thank you, I will fix it
Signed-off-by: remzi <13716567376yh@gmail.com>
|
build |
|
build |
revans2
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi 13716567376yh@gmail.com
close #4446
MapTypeinto unsupported element types in integration testsXfailbyfallbackwhen casting unsupported types to string in integration tests