Added in StringRPad and StringLPad #445
Conversation
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
| @@ -160,15 +160,15 @@ def with_special_pattern(self, pattern, flags=0, charset=sre_yield.CHARSET, weig | |||
| length = int(len(strs)) | |||
| except OverflowError: | |||
| length = _MAX_CHOICES | |||
| return self.with_special_case(lambda rand : strs[rand.randint(0, length)], weight=weight) | |||
| return self.with_special_case(lambda rand : strs[rand.randrange(0, length)], weight=weight) | |||
There was a problem hiding this comment.
I found this during debugging. randrange is not inclusive on the high end, but randint is
| } | ||
| } | ||
| override def convertToGpu( | ||
| str: Expression, |
There was a problem hiding this comment.
IntelliJ is setting that to the indentation with the settings we have published for it. Don't know if it is a regression in IntelliJ or what, but I'll fix it for these
There was a problem hiding this comment.
I saw these were updated, but the style guide doesn't call for aligning arguments with the open parenthesis. Instead it should be a continuation (i.e.: 4-space indent from the start of the previous line). Apparently the style settings that are published are messed up, I'll look into it and fix if necessary.
There was a problem hiding this comment.
I checked the IntelliJ settings file and it appears to be correct. Specifically it calls out these settings which should not have aligned the parameters on the opening parenthesis:
<codeStyleSettings language="Scala">
<option name="ALIGN_MULTILINE_PARAMETERS" value="false" />
<indentOptions>
<option name="CONTINUATION_INDENT_SIZE" value="4" />
</indentOptions>
</codeStyleSettings>
| } | ||
| } | ||
| override def convertToGpu( | ||
| str: Expression, |
| override def children: Seq[Expression] = str :: len :: pad :: Nil | ||
| override def dataType: DataType = StringType | ||
| override def inputTypes: Seq[DataType] = Seq(StringType, IntegerType, StringType) | ||
| override def prettyName: String = "lpad" |
There was a problem hiding this comment.
Shouldn't this be overridden in the derived classes rather than here?
| } | ||
|
|
||
| override def doColumnar( | ||
| str: GpuColumnVector, |
| throw new IllegalStateException("This is not supported yet") | ||
|
|
||
| override def doColumnar( | ||
| str: Scalar, |
| throw new IllegalStateException("This is not supported yet") | ||
|
|
||
| override def doColumnar( | ||
| str: GpuColumnVector, |
| throw new IllegalStateException("This is not supported yet") | ||
|
|
||
| override def doColumnar( | ||
| str: GpuColumnVector, |
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Adds in support for
rpadandlpadThis fixes #438
This depends on some changes to cudf that just were merged in, but because of how CI works, it may be a while before these will build. I'll try to speed up the process.