Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some metadata operators when checking GPU replacement #4458

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

firestarman
Copy link
Collaborator

@firestarman firestarman commented Jan 5, 2022

This fixes #4455 .

The exec for SHOW TABLES in Spark 330+ is changed from ExecutedCommandExec to ShowTablesExec, so add it as an exclusion, along with the DropTableExec which also used in the tests.

Signed-off-by: Firestarman firestarmanllc@gmail.com

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
@firestarman
Copy link
Collaborator Author

build

Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see that this was a simple fix.

@jlowe jlowe merged commit 86a1208 into NVIDIA:branch-22.02 Jan 5, 2022
@firestarman firestarman deleted the fix-test-join branch January 6, 2022 01:39
@sameerz sameerz added the bug Something isn't working label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] join_test.py::test_struct_self_join[IGNORE_ORDER({'local': True})] failed in spark330
4 participants