Add in HashPartitioning support for decimal 128 [databricks] #4470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
added
the
task
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
changed the title
|
build |
|
CI failed on databricks. Fix is in: #4583 . Will kick off the CI again once that PR is merged. |
nartal1
changed the title
|
build |
|
The failure looks like it is a bug in our code when trying to create a scalar of a struct with a Decimal in it. It is related, but not 100% directly to this. I'll see if I can reproduce it. Unfortunately, I am not 100% sure we can fix it without some modifications to the CUDF JNI. But we will see. |
|
I just filed #4600 for the crash. |
nartal1
changed the title
|
build |
|
CI passed. @revans2 PTAL. |
revans2
approved these changes
Jan 24, 2022
This was referenced Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3883, fixes #3885 and fixes #4410.
This PR depends on cudf PR rapidsai/cudf#9919 .
Added DECIMAL_128 support for the Execs and updated the tests.