Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test case of reading nested unsigned parquet file #4483

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Update test case of reading nested unsigned parquet file #4483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99168c5
Update test case of reading nested unsigned parquet file after cudf f…
Jan 10, 2022
488e390
Remove useless orc file
Jan 11, 2022
f77b5ba
Update comments
Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file renamed ...s/src/test/resources/unsigned-int.parquet → ...rc/test/resources/nested-unsigned.parquet
View file
Open in desktop
Binary file not shown.
36 changes: 31 additions & 5 deletions tests/src/test/scala/com/nvidia/spark/rapids/ParquetScanSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019-2021, NVIDIA CORPORATION.
* Copyright (c) 2019-2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -88,8 +88,7 @@ class ParquetScanSuite extends SparkQueryCompareTestSuite {
StructField("c1_int", IntegerType))))) { frame => frame }

/**
* Column schema of unsigned-int.parquet is:
* TODO: array nest type is blocked by issue: https://github.com/rapidsai/cudf/issues/9240
* Schema of nested-unsigned.parquet is:
*
* message root {
* required int32 a (UINT_8);
Expand Down Expand Up @@ -130,9 +129,36 @@ class ParquetScanSuite extends SparkQueryCompareTestSuite {
* }
* }
*
* converted to Spark schema
*
* >>> df.printSchema()
* root
* |-- a: short (nullable = true)
* |-- b: integer (nullable = true)
* |-- c: long (nullable = true)
* |-- g: struct (nullable = true)
* | |-- c1: short (nullable = true)
* | |-- c2: integer (nullable = true)
* | |-- c3: long (nullable = true)
* |-- m1: map (nullable = true)
* | |-- key: short
* | |-- value: short (valueContainsNull = true)
* |-- m2: map (nullable = true)
* | |-- key: integer
* | |-- value: integer (valueContainsNull = true)
* |-- m3: map (nullable = true)
* | |-- key: long
* | |-- value: long (valueContainsNull = true)
* |-- m4: map (nullable = true)
* | |-- key: long
* | |-- value: struct (valueContainsNull = true)
* | | |-- c1: short (nullable = true)
* | | |-- c2: integer (nullable = true)
* | | |-- c3: long (nullable = true)
*
*/
testSparkResultsAreEqual("Test Parquet unsigned int: uint8, uint16, uint32",
frameFromParquet("unsigned-int.parquet"),
testSparkResultsAreEqual("Test Parquet nested unsigned int: uint8, uint16, uint32",
frameFromParquet("nested-unsigned.parquet"),
// CPU version throws an exception when Spark < 3.2, so skip when Spark < 3.2.
// The exception is like "Parquet type not supported: INT32 (UINT_8)"
assumeCondition = (_ => (VersionUtils.isSpark320OrLater, "Spark version not 3.2.0+"))) {
Expand Down