Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the redundant test for element_at and fixed the failing one [databricks] #4502

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Removed the redundant test for element_at and fixed the failing one [databricks] #4502

merged 4 commits into from
Jan 13, 2022

Conversation

razajafri
Copy link
Collaborator

Test for element_at was added erroneously as part of #4464.

This PR removes that test and fixes the original test.

Signed-off-by: Raza Jafri rjafri@nvidia.com

@razajafri
removed the redundant test for element_at and fixed the failing one
e61413f 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri razajafri self-assigned this Jan 11, 2022
@jlowe jlowe added the test Only impacts tests label Jan 11, 2022
jlowe
jlowe previously approved these changes Jan 11, 2022
View reviewed changes
@jlowe
Copy link
Member

jlowe commented Jan 11, 2022

build

@jlowe jlowe added this to the Jan 10 - Jan 28 milestone Jan 11, 2022
@razajafri
Copy link
Collaborator Author

CI failed due to OOM Exception

@razajafri
Copy link
Collaborator Author

build

@razajafri
reduce databricks parallelism
15c8738 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
Copy link
Collaborator Author

build

@razajafri
Copy link
Collaborator Author

This time I think the DB instance reached the idle timeout
[2022-01-13T03:30:07.202Z] ../../src/main/python/cache_test.py::test_cache_partial_load[{'spark.sql.inMemoryColumnarStorage.enableVectorizedReader': 'true'}-Array(String)][ALLOW_NON_GPU(CollectLimitExec)] Connection to 52.183.91.187 closed by remote host.

@razajafri
Revert "reduce databricks parallelism"
50010e6 
This reverts commit 15c8738.

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
Merge remote-tracking branch 'origin/branch-22.02' into HEAD
e410076 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@jlowe
Copy link
Member

jlowe commented Jan 13, 2022

build

1 similar comment
@razajafri
Copy link
Collaborator Author

build

@razajafri razajafri merged commit b64e316 into NVIDIA:branch-22.02 Jan 13, 2022
@razajafri razajafri deleted the SP-fix-3.3 branch January 13, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu

@revans2 revans2 Awaiting requested review from revans2

@tgravescs tgravescs Awaiting requested review from tgravescs

Assignees

@razajafri razajafri

Labels
test Only impacts tests
Projects
None yet
Milestone
Jan 10 - Jan 28
Development

Successfully merging this pull request may close these issues.
2 participants
@razajafri @jlowe