Revert "Disable orc write by default because of https://issues.apache.org/jira/browse/ORC-1075 (#4471)" #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….org/jira/browse/ORC-1075 (NVIDIA#4471)" This reverts commit 8773141. Signed-off-by: Bobby Wang <wbo4958@gmail.com>
|
build |
|
converted to draft since cudf pr still draft |
jlowe
added
the
cudf_dependency
tgravescs
reviewed
Jan 20, 2022
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2020-2022, NVIDIA CORPORATION. | |||
| * Copyright (c) 2020-2021, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
should leave 2022 in there I think
|
build |
jlowe
approved these changes
Jan 20, 2022
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rapidsai/cudf#10041 which has added the column statistic in RowIndex when writing ORC files by CUDF. I tested it locally, it can work. We need to enable GPU accelerated ORC write by default.