regexp_replace with back-references should fall back to CPU #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck-references Signed-off-by: Andy Grove <andygrove@nvidia.com>
…e-backref-fallback
andygrove
changed the title
revans2
previously approved these changes
Jan 18, 2022
jlowe
reviewed
Jan 18, 2022
|
|
||
| expr.rep match { | ||
| case Literal(s: UTF8String, DataTypes.StringType) if s != null => | ||
| val backrefPattern = Pattern.compile("\\$[0-9]") |
There was a problem hiding this comment.
Note that this can create false-positives. A Spark regex replace string of "\\$1" isn't asking for a group but this pattern matcher will think it is.
There was a problem hiding this comment.
I was working on a fix for this but that exposed another issue that I am going to have to fix first, so I will mark this PR as a draft for now.
andygrove
changed the title
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
jlowe
reviewed
Jan 19, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
jlowe
approved these changes
Jan 19, 2022
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4503 and #4559
Follow-on issue to support back-references on the GPU: #4557