Fallback to CPU when encoding is not supported for JSON reader #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
|
build |
sameerz
added
the
task
revans2
approved these changes
Jan 25, 2022
andygrove
reviewed
Jan 25, 2022
| @@ -138,6 +140,11 @@ object GpuJsonScan { | |||
| meta.willNotWorkOnGpu("GpuJsonScan only supports \"\\n\" as a line separator") | |||
| } | |||
|
|
|||
| parsedOptions.encoding.foreach(enc => | |||
| if (enc != StandardCharsets.UTF_8.name() && enc != StandardCharsets.US_ASCII.name()) { | |||
| meta.willNotWorkOnGpu("GpuJsonScan only supports UTF8 or US-ASCII encoded data") | |||
There was a problem hiding this comment.
Could we have the error message include the encoding that is causing us to fall back? This will make it easier for the user to debug.
There was a problem hiding this comment.
Thx for the comment, I'd like to create a follow-up targeting 22.04
andygrove
reviewed
Jan 25, 2022
| @@ -138,6 +140,11 @@ object GpuJsonScan { | |||
| meta.willNotWorkOnGpu("GpuJsonScan only supports \"\\n\" as a line separator") | |||
| } | |||
|
|
|||
| parsedOptions.encoding.foreach(enc => | |||
There was a problem hiding this comment.
nit: could we use exists here instead since this is an Option? Something like:
if (parsedOptions.encoding.exists(enc =>
enc != StandardCharsets.UTF_8.name() && enc != StandardCharsets.US_ASCII.name())) {There was a problem hiding this comment.
Thx for the comment, I'd like to create a follow-up targeting 22.04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falllback to CPU when encoding is not UTF-8 or US-ASCII