Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for reading CSV and JSON floating-point values #4637

Merged
merged 13 commits into from
Feb 2, 2022
Merged

Improve support for reading CSV and JSON floating-point values #4637

merged 13 commits into from
Feb 2, 2022

Commits on Jan 26, 2022

  1. Improve support for reading CSV and JSON floating-point values 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    e83d9ca View commit details
    Browse the repository at this point in the history

  2. scalastyle and add comments

    @andygrove
    andygrove committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    81b1155 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Fix resource leak 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    aa45a26 View commit details
    Browse the repository at this point in the history

  2. Add file reader tests for JSON

    @andygrove
    andygrove committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    45abe08 View commit details
    Browse the repository at this point in the history

  3. more tests

    @andygrove
    andygrove committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    6ebaf4a View commit details
    Browse the repository at this point in the history

  4. docs update

    @andygrove
    andygrove committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    6f35a33 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. ansi mode tests and bug fix 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    01bd647 View commit details
    Browse the repository at this point in the history

  2. add invalid float values so that ansi is covered correctly by the tests

    @andygrove
    andygrove committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    8d1f9c2 View commit details
    Browse the repository at this point in the history

  3. add invalid floats to csv_test

    @andygrove
    andygrove committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    334a2fc View commit details
    Browse the repository at this point in the history

  4. Remove Nan/Inf values from simple_float_values.csv and enable overflo… 

    …w tests. Also update compatibility guide.

Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    240ac19 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. move withResource to enclose for loop

    @andygrove
    andygrove committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    001d549 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. fix test regression

    @andygrove
    andygrove committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    085a5cb View commit details
    Browse the repository at this point in the history

  2. change maxFloatDiff to 1e-6

    @andygrove
    andygrove committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    5d70ced View commit details
    Browse the repository at this point in the history