Update HashAggregateSuite to work with AQE #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
revans2
reviewed
Jul 30, 2020
|
build |
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
andygrove
reviewed
Jul 30, 2020
|
|
||
| gpuPlan match { | ||
| case WholeStageCodegenExec(GpuColumnarToRowExec(plan, _)) => | ||
| assert(plan.children.head.isInstanceOf[GpuHashAggregateExec]) | ||
| assert(gpuPlan.find(_.isInstanceOf[SortAggregateExec]).isEmpty) | ||
| assert(gpuPlan.children.forall(exec => exec.isInstanceOf[GpuExec])) | ||
|
|
||
| case a: AdaptiveSparkPlanExec => |
There was a problem hiding this comment.
I think it would be good to revisit creating helper utilities for inspecting plans, that can work both with adaptive and non-adaptive plans so we don't end up with lots of duplicate code in tests. I don't think it has to be part of this PR though.
There was a problem hiding this comment.
Thanks @andygrove . I have created a follow-on issue for creating helper utilities #476
|
build |
revans2
approved these changes
Jul 30, 2020
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Update HashAggregateSuite to work with AQE Signed-off-by: Niranjan Artal <nartal@nvidia.com> * addressed review comments Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Update HashAggregateSuite to work with AQE Signed-off-by: Niranjan Artal <nartal@nvidia.com> * addressed review comments Signed-off-by: Niranjan Artal <nartal@nvidia.com>
pxLi
pushed a commit
to pxLi/spark-rapids
that referenced
this pull request
May 12, 2022
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Niranjan Artal nartal@nvidia.com
Updated tests and verified locally. This closes #453.