Add clarifications and details to integration-tests README [skip ci] #4694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
jlowe
changed the title
jlowe
changed the title
jlowe
reviewed
Feb 5, 2022
jlowe
reviewed
Feb 7, 2022
integration_tests/README.md
Outdated
| export PATH=$M2:$PATH | ||
| ``` | ||
|
|
||
| </details> |
There was a problem hiding this comment.
This looks like a closing tag with no matching <details> tag.
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
sameerz
reviewed
Feb 7, 2022
integration_tests/README.md
Outdated
|
|
||
| #### Installing specific version of Maven | ||
|
|
||
| All package managers like `brew` and `apt` offers maven. However, it may lag behind some |
There was a problem hiding this comment.
Suggested change
| All package managers like `brew` and `apt` offers maven. However, it may lag behind some | |
| All package managers like `brew` and `apt` offer maven. However, it may lag behind some |
sameerz
approved these changes
Feb 11, 2022
|
build |
jlowe
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4693
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me