Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim join tests to improve runtime of tests #4731

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Feb 9, 2022

Relates to #4538.

This trims quite a bit of test combinations from the join integration tests. Joins test on many dimensions such as join type, data type, and batch size. Some joins can take a long time, and we run them twice (CPU+GPU), so doing every combination contributes to the very long runtime for all the join tests.

The tests were trimmed with the following guidelines:

  • It does not seem necessary for special-case count joins to test every possible input type since it's just a count, so those tests were updated to use a single input type.
  • It does not seem necessary to test every combination of join type and data type on small batch sizes when the same combination of join type and data type are being tested at larger sizes. Dealing with small batch sizes is more about managing gather maps and calling gather appropriately than the actual data types themselves. In addition, small batch sizes can take quite a long time for some joins. Therefore the tests were updated to only test a small subset of input types on small batch combinations.
  • There were many decimal types being tested that added no extra code coverage, since joins don't care about decimal scale settings. The decimal types were trimmed to test one precision/scale combination for 32-bit, 64-bit, and 128-bit decimal types, respectively.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the test Only impacts tests label Feb 9, 2022
@jlowe jlowe added this to the Jan 31 - Feb 11 milestone Feb 9, 2022
@jlowe jlowe self-assigned this Feb 9, 2022
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We still cover all of the types we covered before (with some fewer decimal types). We also cover the smaller number of batches better.

@jlowe
Copy link
Member Author

jlowe commented Feb 9, 2022

build

@jlowe jlowe merged commit 9705fab into NVIDIA:branch-22.04 Feb 9, 2022
@jlowe jlowe deleted the trim-join-tests branch February 9, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants