Enable regular expressions on GPU by default [databricks] #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
revans2
previously approved these changes
Feb 10, 2022
| @@ -351,14 +351,12 @@ abstract class Spark30XdbShims extends Spark30XdbShimsBase with Logging { | |||
| override def convertToGpu(child: Expression): GpuExpression = GpuAbs(child, false) | |||
| }), | |||
| GpuOverrides.expr[RegExpReplace]( | |||
| "RegExpReplace support for string literal input patterns", | |||
| "RegExpReplace", | |||
There was a problem hiding this comment.
I personally would rather have a description of what this does and not the name of it again.
"String replace using a regular expression"
| @@ -297,14 +297,12 @@ abstract class Spark30XShims extends Spark301until320Shims with Logging { | |||
| override def convertToGpu(child: Expression): GpuExpression = GpuAbs(child, false) | |||
| }), | |||
| GpuOverrides.expr[RegExpReplace]( | |||
| "RegExpReplace support for string literal input patterns", | |||
| "RegExpReplace", | |||
| @@ -207,17 +207,15 @@ abstract class Spark31XShims extends Spark301until320Shims with Logging { | |||
| override def convertToGpu(child: Expression): GpuExpression = GpuAbs(child, false) | |||
| }), | |||
| GpuOverrides.expr[RegExpReplace]( | |||
| "RegExpReplace support for string literal input patterns", | |||
| "RegExpReplace", | |||
| @@ -206,17 +206,15 @@ abstract class Spark31XdbShims extends Spark31XdbShimsBase with Logging { | |||
| override def convertToGpu(child: Expression): GpuExpression = GpuAbs(child, false) | |||
| }), | |||
| GpuOverrides.expr[RegExpReplace]( | |||
| "RegExpReplace support for string literal input patterns", | |||
| "RegExpReplace", | |||
| @@ -309,7 +309,7 @@ trait Spark320PlusShims extends SparkShims with RebaseShims with Logging { | |||
| override def convertToGpu(child: Expression): GpuExpression = GpuAbs(child, ansiEnabled) | |||
| }), | |||
| GpuOverrides.expr[RegExpReplace]( | |||
| "RegExpReplace support for string literal input patterns", | |||
| "RegExpReplace", | |||
jlowe
reviewed
Feb 10, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/301db/scala/com/nvidia/spark/rapids/shims/v2/GpuRegExpReplaceExec.scala
Outdated
Show resolved
Hide resolved
...src/main/301until310-nondb/scala/com/nvidia/spark/rapids/shims/v2/GpuRegExpReplaceMeta.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/301db/scala/com/nvidia/spark/rapids/shims/v2/GpuRegExpReplaceExec.scala
Outdated
Show resolved
Hide resolved
…cala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
jlowe
reviewed
Feb 10, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
…nctions.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
andygrove
changed the title
jlowe
approved these changes
Feb 10, 2022
|
build |
revans2
approved these changes
Feb 10, 2022
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
This PR adds a new config option
spark.rapids.sql.regexp.enabledwhich defaults totrueand enables all existing regular expression support on GPU, such asRLike,RegExp,RegExpReplace, andRegExpExtract. This replaces the previous approach of disabling individual expression classes by default.