Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeowners #481

Merged
merged 6 commits into from
Aug 3, 2020
Merged

Codeowners #481

merged 6 commits into from
Aug 3, 2020

Conversation

sameerz
Copy link
Collaborator

@sameerz sameerz commented Jul 31, 2020

  1. Please write a description in this text box of the changes that are being
    made.

Add codeowners for jenkins folder for review.

  1. Please ensure that you have written units tests for the changes made/features
    added.

Not tested. Will need to enable required reviews for pull requests per https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#about-code-owners

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@sameerz sameerz added the build Related to CI / CD or cleanly building label Jul 31, 2020
CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
jlowe
jlowe previously approved these changes Jul 31, 2020
@jlowe
Copy link
Member

jlowe commented Jul 31, 2020

build

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@sameerz
Copy link
Collaborator Author

sameerz commented Aug 1, 2020

I added pom.xml to CODEOWNERS, please review again.

Also added a license header.

@sameerz sameerz added this to the Aug 3 - Aug 14 milestone Aug 3, 2020
@jlowe
Copy link
Member

jlowe commented Aug 3, 2020

build

@jlowe jlowe merged commit 26943c4 into NVIDIA:branch-0.2 Aug 3, 2020
@sameerz sameerz deleted the codeowners branch August 24, 2020 22:32
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Add codeowners for jenkins build files

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Add codeowners for jenkins build files (fix users)

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Add codeowners for jenkins build files (fix users)

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Add codeowners for jenkins build files (fix users)

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* moved CODEOWNERS to .github

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* added license header, added pom.xml to CODEOWNERS

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Add codeowners for jenkins build files

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Add codeowners for jenkins build files (fix users)

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Add codeowners for jenkins build files (fix users)

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Add codeowners for jenkins build files (fix users)

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* moved CODEOWNERS to .github

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* added license header, added pom.xml to CODEOWNERS

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
pxLi pushed a commit to pxLi/spark-rapids that referenced this pull request May 12, 2022
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…ci] (NVIDIA#481)

* add DOCKER_NETWORKING variable

Signed-off-by: Bobby Wang <wbo4958@gmail.com>

* resolve comments

Signed-off-by: Bobby Wang <wbo4958@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants