Improve date support in JSON and CSV readers #4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
9 tasks
andygrove
commented
Mar 7, 2022
Comment on lines
-170
to
-177
| 'spark.rapids.sql.csv.read.bool.enabled': 'true', | ||
| 'spark.rapids.sql.csv.read.date.enabled': 'true', | ||
| 'spark.rapids.sql.csv.read.byte.enabled': 'true', | ||
| 'spark.rapids.sql.csv.read.short.enabled': 'true', | ||
| 'spark.rapids.sql.csv.read.integer.enabled': 'true', | ||
| 'spark.rapids.sql.csv.read.long.enabled': 'true', | ||
| 'spark.rapids.sql.csv.read.float.enabled': 'true', | ||
| 'spark.rapids.sql.csv.read.double.enabled': 'true', |
There was a problem hiding this comment.
Most of these options were removed from the configs in earlier PRs related to JSON support
andygrove
changed the title
|
build |
revans2
reviewed
Mar 7, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/DateUtils.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuBatchScanExec.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuTextBasedPartitionReader.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuTextBasedPartitionReader.scala
Show resolved
Hide resolved
| @@ -150,7 +150,6 @@ trait SparkQueryCompareTestSuite extends FunSuite with Arm { | |||
|
|
|||
| def enableCsvConf(): SparkConf = { | |||
There was a problem hiding this comment.
Should we just delete this?
|
It also looks like some versions of Spark do not include a dateFormat option. |
revans2
previously approved these changes
Mar 7, 2022
|
build |
|
build |
revans2
previously approved these changes
Mar 7, 2022
|
Build failed with Spark 3.3.0 I will need to do some shim work next |
|
build |
|
build |
revans2
previously approved these changes
Mar 8, 2022
|
build |
|
@revans2 I fixed the issues with 3.3.0 and tests are now passing |
revans2
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4849 and #1091 and partially fixes #1111 and #123
Adds support for reading date columns from JSON and CSV, respecting
timeParserPolicy.Status: