Support running GetArrayStructFields on GPU[databricks]
#4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman
changed the title
GetArrayStructFields on GPUGetArrayStructFields on GPU[databricks]
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
revans2
previously approved these changes
Feb 28, 2022
| structView.getChildColumnView(ordinal) | ||
| } | ||
| val listView = withResource(fieldView) { _ => | ||
| new ColumnView(DType.LIST, base.getRowCount, Optional.of[java.lang.Long](base.getNullCount), |
There was a problem hiding this comment.
nit: Could you use GpuListUtils.replaceListDataColumnAsView instead? It does the same thing, but adds a few more checks, and would make more of this kind of scary code common.
There was a problem hiding this comment.
Good to know this.
jlowe
previously approved these changes
Feb 28, 2022
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
revans2
approved these changes
Mar 1, 2022
|
build |
1 similar comment
|
build |
|
#4881 is to fix the build error in premerge. |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding the support of running
GetArrayStructFieldson GPU, along with the relevant tests.closes #4816
Signed-off-by: Firestarman firestarmanllc@gmail.com