Disable write/read Parquet when Parquet field IDs are used #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rquet field ID Signed-off-by: Chong Gao <res_life@163.com>
res-life
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
jlowe
reviewed
Mar 1, 2022
sql-plugin/src/main/330+/scala/com/nvidia/spark/rapids/shims/v2/ParquetFieldIdShims.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/330+/scala/com/nvidia/spark/rapids/shims/v2/ParquetFieldIdShims.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/330+/scala/com/nvidia/spark/rapids/shims/v2/ParquetFieldIdShims.scala
Outdated
Show resolved
Hide resolved
tests/src/test/330+/scala/com/nvidia/spark/rapids/ParquetFieldIdSuite.scala
Outdated
Show resolved
Hide resolved
jlowe
changed the title
added 3 commits
March 2, 2022 17:11
jlowe
approved these changes
Mar 2, 2022
revans2
approved these changes
Mar 2, 2022
|
build |
1 similar comment
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily disable write/read parquet when schema has a specified Parquet field ID
Solution is: Fallback to CPU when writing Parquet with field id column. Fallback to CPU if
"spark.sql.parquet.fieldId.read.enabled" is true when reading Parquet.
Contributes #4846
Signed-off-by: Chong Gao res_life@163.com