Fixed Decimal 128 bug in ParquetCachedBatchSerializer #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
1 similar comment
|
build |
revans2
previously approved these changes
Mar 7, 2022
gerashegalov
reviewed
Mar 7, 2022
.../src/main/311+-all/scala/com/nvidia/spark/rapids/shims/v2/ParquetCachedBatchSerializer.scala
Show resolved
Hide resolved
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
gerashegalov
approved these changes
Mar 8, 2022
jlowe
approved these changes
Mar 8, 2022
|
Do we also need to update it for the 320+ shims ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the way we were reading the parquet schema on the CPU. The problem was that the
SparkToParquetSchemaConverterdoesn't honor the 8-byte alignment, instead it changes the schema to the minimum bits needed to store the value which was causing PCBS to not read the entire value thus resulting in test failuresfixes #4826
Signed-off-by: Raza Jafri rjafri@nvidia.com