Support predictors on ANSI day time interval type #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
|
build |
|
build |
|
build |
|
build |
|
@revans2 Help to review |
revans2
previously approved these changes
Mar 15, 2022
sql-plugin/src/main/301until330-all/scala/com/nvidia/spark/rapids/shims/GpuTypeShims.scala
Outdated
Show resolved
Hide resolved
added 2 commits
March 16, 2022 11:12
|
build |
|
build |
revans2
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4945
Closes #4149
Support predictors on ANSI day time interval type
IsNull, IsNotNull, EqualNullSafe, EqualTo, GreaterThan, GreaterThanOrEqual, LessThan, LessThanOrEqual, FilterExec
Add test for pushdown ANSI interval type.
No need to change code, only need to add a test case.
Parquet stores day-time interval as long and the statistics on day-time interval are values of max(long) and min(long).
ParquetFilters.createFilter already converts filters on day-time to filters on long.
Add converter from ANSI day time literal to scalar
Signed-off-by: Chong Gao res_life@163.com