Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Spark 3.0.x [databricks] #4988

Merged
merged 5 commits into from
Mar 21, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 18, 2022

Contributes to #4915.

This removes support for Spark 3.0.x and the corresponding shims. Work to "unshim" interfaces that no longer need to be shimmed now that 3.1.x is the base version will be handled in a followup PR.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe requested a review from revans2 as a code owner March 18, 2022 21:07
@jlowe jlowe self-assigned this Mar 18, 2022
@jlowe
Copy link
Member Author

jlowe commented Mar 18, 2022

build

@sameerz sameerz added the feature request New feature or request label Mar 18, 2022
@sameerz sameerz added this to the Mar 21 - Apr 1 milestone Mar 18, 2022
@tgravescs
Copy link
Collaborator

first just checked for other places used - CONTRIBUTING.md I think still references 301 in mvn -Dbuildver=301 install -DskipTests and VersionUtils.scala still has isSpark301OrLater that I don't think is used

Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick pass and it looks good. I need to look more deeply at the different files to provide better suggestions.

Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, looks like needs upmerged now.

@jlowe
Copy link
Member Author

jlowe commented Mar 18, 2022

build

@jlowe
Copy link
Member Author

jlowe commented Mar 18, 2022

build

tgravescs
tgravescs previously approved these changes Mar 18, 2022
@pxLi
Copy link
Collaborator

pxLi commented Mar 21, 2022

As pre-merge jenkins file change will not take effect in this PR, taking care of it in #4990. Please help revert change to Jenkinsfile.premerge, thanks!

Test failures,

Exception: Python in worker has different version 3.6 than that in driver 3.8, PySpark cannot run with different minor versions. Please check environment variables PYSPARK_PYTHON and PYSPARK_DRIVER_PYTHON are correctly set.

required python version changed, will also update image.

Also created issue #4991 to drop the compatibility support in premerge Jenkinsfile

@jlowe
Copy link
Member Author

jlowe commented Mar 21, 2022

build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants