Use conf.useCompression config to decide if we should be compressing the cache [databricks] #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
jlowe
reviewed
Mar 21, 2022
...gin/src/main/311+-all/scala/com/nvidia/spark/rapids/shims/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
|
Has this been tested? I think the default compression type will also encode Snappy, so I wouldn't be surprised if this change had no effect as written. |
I tested this by |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
I found a problem with cudf and created an issue for it in that repo here Converting this PR to draft until that bug is fixed |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
changed the title
|
build |
sameerz
added
the
task
|
@jlowe do you have any more concerns? |
jlowe
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes PCBS to honor the
conf.useCompressionto decide if cache should be compressed using SNAPPYSigned-off-by: Raza Jafri rjafri@nvidia.com