Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unshim many expressions [databricks] #5036

Merged
merged 8 commits into from
Mar 25, 2022
Merged

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 24, 2022

This is part of #5005. Unshims the expression implementations that were common across all supported Spark versions. GpuTimeSub was removed since it is no longer referenced.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added this to the Mar 21 - Apr 1 milestone Mar 24, 2022
@jlowe jlowe self-assigned this Mar 24, 2022
@jlowe jlowe changed the title Unshim many expressions Unshim many expressions [databricks] Mar 24, 2022
revans2
revans2 previously approved these changes Mar 24, 2022
@jlowe
Copy link
Member Author

jlowe commented Mar 24, 2022

build

1 similar comment
@jlowe
Copy link
Member Author

jlowe commented Mar 24, 2022

build

@jlowe jlowe closed this Mar 24, 2022
@jlowe jlowe reopened this Mar 24, 2022
@jlowe
Copy link
Member Author

jlowe commented Mar 24, 2022

build

@jlowe
Copy link
Member Author

jlowe commented Mar 24, 2022

build

@jlowe
Copy link
Member Author

jlowe commented Mar 24, 2022

build

@sameerz sameerz added the task Work required that improves the product but is not user facing label Mar 24, 2022
@jlowe
Copy link
Member Author

jlowe commented Mar 24, 2022

Build failed due to missing imports in branch-22.06 code, will be fixed by #5040

@pxLi
Copy link
Collaborator

pxLi commented Mar 25, 2022

build

@jlowe jlowe requested a review from revans2 March 25, 2022 15:21
@jlowe jlowe merged commit e845b87 into NVIDIA:branch-22.06 Mar 25, 2022
@jlowe jlowe deleted the unshim-31x-exprs branch March 25, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants