Update Spark 2.x explain API with changes in 22.04 #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4908
This updates all the Spark 2.x explain api code to pull over checks from the changes to the 22.04 code.
I updated diff scripts and checks all the Overrides to try to catch anything new added.
I tested using the NDS queries. I diff'd the new output of 22.04 vs the 22.02 explain api output and the main differences now seem to be with ExistenceJoin being supported and then LeftSemi join. Unfortunately I also found a case the Spark 2.x planner inserts EqualNullSafe, which we don't support on the GPU, but in Spark 3.x it doesn't generate that, it uses other expressions so in Spark 3.x it does say it will run on the GPU. I documented that one.
I also diff'd the results vs explain on 3.1 and didn't see anything we missed.