Remove single-buffer compression codec APIs #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
jbrennan333
previously approved these changes
Mar 30, 2022
abellina
previously approved these changes
Mar 30, 2022
abellina
reviewed
Mar 30, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/CopyCompressionCodec.scala
Show resolved
Hide resolved
|
build |
abellina
approved these changes
Mar 30, 2022
|
CI failed in a way that looked like somehow the Spark session was shut down during the tests. No idea how this happened, and I cannot reproduce locally. |
|
build |
This was referenced Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvcomp 2.2 removed the single-buffer compression/decompression APIs for LZ4. The compression codecs in the RAPIDS Accelerator provide an API for single-buffer compress/decompress, but they are not used. Only the batched APIs are needed, and those are still supported by nvcomp 2.2.
This removes the unused single-buffer compression/decompression APIs in the RAPIDS Accelerator which unblocks the removal of single-buffer codec bindings in cudf.