Fix GpuFileFormatDataWriter failing to stat file after commit #5107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
gerashegalov
reviewed
Apr 4, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/BasicColumnarWriteStatsTracker.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/BasicColumnarWriteStatsTracker.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/BasicColumnarWriteStatsTracker.scala
Show resolved
Hide resolved
|
Thanks for the review, @gerashegalov. I'd like to leave the nits as-is, as it reflects the existing Spark code in |
gerashegalov
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5084.
#3345 moved the location of stats collection to after file commit, but with some file committers the file is renamed by the commit and therefore trying to stat the original path can fail. #3345 simply ported a change from Spark, but the reason Spark didn't have the same issue is because it also had the changes from apache/spark@7f51106.
This PR makes similar changes to the task stats write tracker to remove the unused
newBucketmethod and adds the newcloseFilemethod to handle updating file stats before commit.