Upgrade to UCX 1.12.1 for 22.06 #5141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
|
build |
jlowe
reviewed
Apr 5, 2022
jlowe
previously approved these changes
Apr 5, 2022
|
build |
jlowe
approved these changes
Apr 5, 2022
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4695.
This PR separates out the upgrade to UCX 1.12.1 from #4357.
I have run with UCX 1.12.1, both against our old jucx 1.11 jar and against jucx 1.12.1, and I do not see performance issues.
I also ran with the ASYNC allocator and ARENA, and I cannot reproduce the segfault with async noted here. #4695