Update the log warning of UDF compiler #5157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <13716567376yh@gmail.com>
HaoYang670
changed the title
jlowe
reviewed
Apr 7, 2022
Signed-off-by: remzi <13716567376yh@gmail.com>
|
build |
HaoYang670
changed the title
gerashegalov
reviewed
Apr 9, 2022
| @@ -90,6 +90,14 @@ object RapidsPluginUtils extends Logging { | |||
| logWarning("RAPIDS Accelerator is disabled, to enable GPU " + | |||
| s"support set `${RapidsConf.SQL_ENABLED}` to true.") | |||
| } | |||
|
|
|||
| if (conf.isUdfCompilerEnabled) { | |||
| logWarning("RAPIDS UDF compiler is enabled, to disable it " + | |||
There was a problem hiding this comment.
We might want to link to our FAQ https://nvidia.github.io/spark-rapids/docs/FAQ.html#automatic-translation-of-scala-udfs-to-apache-spark-operations . Without such context it's not clear for the user why she is warned about this setting. What makes it different from other switches we don't draw attention to? Looks like we consider it bleeding edge (experimental, unstable, evolving), and the wording for the warning should make it clear. E.g.
Experimental RAPIDS UDF compiler is enabled, in case of related failures disable it by ...
| logWarning("RAPIDS UDF compiler is enabled, to disable it " + | ||
| s"set `${RapidsConf.UDF_COMPILER_ENABLED}` to false.") | ||
| } else { | ||
| logWarning("RAPIDS UDF compiler is disabled, to enable it " + |
There was a problem hiding this comment.
+1 to @jlowe's comment #5157 (comment) .
Signed-off-by: remzi <13716567376yh@gmail.com>
|
build |
jlowe
approved these changes
Apr 11, 2022
abellina
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi 13716567376yh@gmail.com
Close #5104.
Update the log warning. Delete the content of how to enable udf compiler.