Terminate test earlier if pytest ENV issue [skip ci] #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxLi
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
GaryShen2008
previously approved these changes
Apr 8, 2022
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
force-pushed
the
catch-pytest-collect-only-execption
branch
from
61902f5
to
5f90b3c
Compare
|
build |
|
retargeted to 22.04 |
GaryShen2008
approved these changes
Apr 8, 2022
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peixin Li pxli@nyu.edu
We saw get cases/tests by tag funcs could hide errors in pipefails
Instead of deal w/ PIPESTATUS and adjust string manipulation, we simply add a pytest ENV check (~20s) before the actual test run which will also expose all stdout&stderr to console. e.g. SPARK ENV issue, cuda ENV issue, pytest dep issue, etc
also remove redundant 311 ver check since we support spark311+ only
tested internally.