Fix test failure with Spark 3.3 by looking for less specific error message #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
temp-workadound-issue-5182
branch
from
1e3cb7a
to
a6193b1
Compare
andygrove
changed the title
|
build |
tgravescs
approved these changes
Apr 8, 2022
jlowe
reviewed
Apr 8, 2022
| @@ -788,7 +788,7 @@ def test_div_overflow_exception_when_ansi(expr, ansi_enabled): | |||
| assert_gpu_and_cpu_error( | |||
| df_fun=lambda spark: _get_div_overflow_df(spark, expr).collect(), | |||
| conf=ansi_conf, | |||
| error_message='java.lang.ArithmeticException: Overflow in integral divide') | |||
| error_message='ArithmeticException: Overflow in integral divide') | |||
There was a problem hiding this comment.
Isn't the point to ensure we're throwing the same exception? As such I'd rather see this test check for the correct exception class based on the Spark version -- if Spark 3.3 throws a different exception for this, then our plugin should throw the same class for the same type of exception on Spark 3.3.
I'm OK if we want to do this as a followup to refine the test if we aren't already doing the correct behavior now. If we are, then this should choose a different message to check based on which Spark we're using as is done in other tests checking exception types.
There was a problem hiding this comment.
Yes, that's a good point. I filed #5196 as a follow-on.
jlowe
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5182
Spark 3.3 changed which exception they throw for a divide that causes an overflow in apache/spark@c2ed15d, causing our tests to fail.
This PR changes the affected test to just look for
ArithmeticExceptionrather than specificallyjava.lang.ArithmeticException. This is the same approach used in the other tests.