Refactor Spark33XShims to avoid code duplication #5195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
|
A known issue caused Check Markdown links failed |
res-life
changed the title
res-life
changed the title
res-life
changed the title
firestarman
reviewed
Apr 11, 2022
| override def convertToGpu(): GpuExec = | ||
| GpuBatchScanExec(p.output, childScans.head.convertToGpu(), p.runtimeFilters) | ||
| }) | ||
| (p, conf, parent, r) => new BatchScanExecMeta320Plus(p, conf, parent, r)) |
There was a problem hiding this comment.
NIT:
Personally I prefer BatchScanExecMeta to BatchScanExecMeta320Plus.
|
LGTM except a nit as the above. |
|
build |
jlowe
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5150
Refector Spark33XShims
Signed-off-by: Chong Gao res_life@163.com