Perform explicit UnsafeRow projection in ColumnarToRow transition #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
Keeping this as a draft until this gets some at-scale performance tests |
|
build |
|
Premerge failed due to transitive Cloudera dependency, rekicking the build. |
|
build |
abellina
reviewed
Apr 19, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuRowToColumnarExec.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuRowToColumnarExec.scala
Show resolved
Hide resolved
abellina
previously approved these changes
Apr 19, 2022
|
build |
|
The latest code changes do not appear to have a significant performance impact. Thanks to @mattahrens for running some performance tests. This should now be ready for review. |
jlowe
requested review from
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
|
build |
|
@revans2 @tgravescs if one of you could take a look that would be great, as it needs a codeowner approval as well. |
abellina
reviewed
Apr 25, 2022
abellina
reviewed
Apr 25, 2022
abellina
reviewed
Apr 25, 2022
revans2
previously approved these changes
Apr 25, 2022
sql-plugin/src/main/java/com/nvidia/spark/rapids/UnsafeRowToColumnarBatchIterator.java
Show resolved
Hide resolved
|
build |
abellina
approved these changes
Apr 25, 2022
revans2
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5189.
The row to columnar transition was assuming that every row coming in was an
UnsafeRowbut that is not always the case. This adds an explicit unsafe projection to the generated unsafe row iterator to handle those cases.