Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spark330 build due to mapKeyNotExistError changed #5352

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fix spark330 build due to mapKeyNotExistError changed #5352

merged 1 commit into from
Apr 28, 2022

Conversation

res-life
Copy link
Collaborator

Closes #5351

Signed-off-by: Chong Gao res_life@163.com

Fix spark330 build due to mapKeyNotExistError changed
a049bb9 
Signed-off-by: Chong Gao <res_life@163.com>
@res-life
Copy link
Collaborator Author

build

@res-life
Copy link
Collaborator Author

Build failed because the CI did not pull the latest spark-catalyst jar.
Trigged the nightly build to get a new spark-catalyst jar and it's done.

@res-life
Copy link
Collaborator Author

build

@sperlingxx
Copy link
Collaborator

LGTM

@res-life res-life mentioned this pull request Apr 28, 2022
Merged
@jlowe jlowe added the build Related to CI / CD or cleanly building label Apr 28, 2022
@jlowe jlowe added this to the Apr 18 - Apr 29 milestone Apr 28, 2022
@jlowe
Copy link
Member

jlowe commented Apr 28, 2022

@res-life please add useful descriptions in PRs. Minimally the description should summarize what is being changed rather than just "close #xxx". For this PR, the summary says it's fixing a problem due to mapKeyNotExistError changed but not how it's fixing it. We don't need a treatise, but a sentence or two summarizing the changes is very helpful.

@jlowe jlowe merged commit 0bfa587 into NVIDIA:branch-22.06 Apr 28, 2022
@res-life
Copy link
Collaborator Author

@res-life please add useful descriptions in PRs. Minimally the description should summarize what is being changed rather than just "close #xxx". For this PR, the summary says it's fixing a problem due to mapKeyNotExistError changed but not how it's fixing it. We don't need a treatise, but a sentence or two summarizing the changes is very helpful.

thanks for your reminder. I'll keep adding descriptions in the coming PRs.

@res-life res-life deleted the mapKeyNotExistError branch May 23, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@tgravescs tgravescs tgravescs approved these changes

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
Apr 18 - Apr 29
Development

Successfully merging this pull request may close these issues.

[BUG] Build fails for Spark 3.3 due to extra arguments to mapKeyNotExistError
4 participants
@res-life @sperlingxx @jlowe @tgravescs